Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit delegate types in same module as their associated proxy type #570

Merged
merged 3 commits into from
Jan 31, 2021

Conversation

stakx
Copy link
Member

@stakx stakx commented Jan 30, 2021

Fixes #569. See commit messages for details.

Back in 9538390 an issue was fixed where DynamicProxy would not always
put a generated invocation type in the same dynamic module as the proxy
type relying on it. It appears the same issue still exists for generated
delegate types. (Those are generated for class proxies when proceeding
from intercepted protected methods to the target.)
Thanks to 9538390 the necessary infrastructure is already in place,
and we can apply exactly the same fix for delegate types.
@stakx
Copy link
Member Author

stakx commented Jan 31, 2021

Nothing spectacular to be seen here, this simply applies a previous bug fix to another location that was overlooked back then.

@stakx stakx merged commit c2649e3 into castleproject:master Jan 31, 2021
@stakx stakx deleted the delegate-types-module-affinity branch January 31, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicProxy generates two modules when proceeding from a class proxy's protected method to the target
1 participant